feat: text formatting #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mint-dewit
force-pushed
the
SOFIE-2799-text-formatting
branch
from
9b21a50 to
2865997
Compare
nytamin
approved these changes
Feb 26, 2024
| if (state.peek(2) !== 'X)') return | ||
|
|
||
| state.consume() | ||
| state.consume() |
There was a problem hiding this comment.
Is there a particular reason this is done twice?
Comment on lines
64
to
65
| char += state.consume() | ||
| // char += state.consume() |
There was a problem hiding this comment.
Not consumed twice here, despite the comment?
jstarpl
approved these changes
Mar 12, 2024
| @@ -24,6 +27,13 @@ export class ParserStateImpl implements ParserState { | |||
| }) | |||
| this.buffer = '' | |||
| } | |||
| setMarker = () => { | |||
There was a problem hiding this comment.
Maybe this should be called pushLeaf (i.e. a node that has no children) and accept an argument of NodeBase? I was expecting setMarker to have something to do with ProseMirror markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: feature
Current Behavior
New Behavior
Following text formatting should be available
Testing Instructions
Ctrl-b, ctrl-i, ctrl-u, ctrl-r, ctrl-f10, ctrl-f and ctrl-k respectively should toggle the text. (Or cmd instead of ctrl on mac)
For colours the shortcut will cycle through the various options.
Other Information
There used to be a shortcut on ctrl-q, I think I removed that for testing because cmd-q quits the entire application. might have accidentally committed it. oops. I'm not sure how sold we are on the current shortcuts and not having a toolbar in place anyway.
Status