Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade rspack to 0.4.4 #352

Merged
merged 12 commits into from
Dec 21, 2023
Merged

feat: upgrade rspack to 0.4.4 #352

merged 12 commits into from
Dec 21, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Nov 28, 2023

upgrade Rspack to 0.4.4, https://www.rspack.dev/blog/announcing-0.4.html#rspack-04-major-changes

This contains break change since experiments.rspackFuture.disableTransformByDefault is enabled by default in Rspack 0.4

Copy link

nx-cloud bot commented Nov 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32c9a00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --target=e2e --parallel --max-parallel=1 --exclude=nx-ignore-e2e,gatsby-e2e
✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@@ -40,7 +40,7 @@ export async function rspackInitGenerator(
}

if (schema.style === 'less') {
devDependencies['@rspack/less-loader'] = rspackLessLoaderVersion;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rspack/less-loader is deprecated and should use less-loader instead

@jaysoo jaysoo self-requested a review December 6, 2023 19:00
@jaysoo jaysoo self-assigned this Dec 6, 2023
@ahabhgk ahabhgk changed the title feat: compatible with rspack 0.4 feat: upgrade to rspack 0.4 Dec 7, 2023
@ahabhgk ahabhgk changed the title feat: upgrade to rspack 0.4 feat: upgrade rspack to 0.4.2 Dec 7, 2023
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Dec 7, 2023

FAIL rspack-e2e e2e/rspack-e2e/tests/rspack.spec.ts (94.123 s), seems e2e of the generated project (tmp/nx-e2e/proj) are failed, but it passes when I run yarn run e2e under tmp/nx-e2e/proj

@jaysoo
Copy link
Member

jaysoo commented Dec 12, 2023

It looks like ReactRefresh is being used in non-dev builds too, so it's causing Cypress test to fail due to React's warning against it in production mode.

@jaysoo
Copy link
Member

jaysoo commented Dec 12, 2023

It also looks like Nest is failing the e2e test. It cannot compile the decorator in app.module.ts.

I see something like this:


> nx run app3456491:build:production

PublicPath: /
asset assets/.gitkeep 0 bytes [emitted]
asset main.js 9.73 KiB [emitted] (name: main)
Entrypoint main 9.73 KiB = main.js
runtime modules 9 modules
./app3456491/src/main.ts
external ["@nestjs/core"]
external ["@nestjs/common"]
./app3456491/src/app/app.module.ts
  × Error[javascript]: JavaScript parsing error
   ╭─[app3456491/src/app/app.module.ts:5:1]
 5 │
 6 │ @Module({
   · ┬
   · ╰── Expression expected
 7 │   imports: [],
   ╰────

Rspack 0.4.3 compiled with 1 error in 35 ms (befe8ffbdb5228c52c4b)

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Dec 13, 2023

Thanks for your help! There is still a bug on Rspack side which breaks license-webpack-plugin, will ship the fix in 0.4.4, I will update the PR when it is released

@ahabhgk ahabhgk changed the title feat: upgrade rspack to 0.4.2 feat: upgrade rspack to 0.4.4 Dec 21, 2023
Copy link

nx-cloud bot commented Dec 21, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c974ef2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@ahabhgk ahabhgk requested a review from jaysoo December 21, 2023 10:16
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Dec 21, 2023

Ready for review!

@jaysoo jaysoo merged commit cb0db89 into nrwl:main Dec 21, 2023
6 checks passed
@ahabhgk ahabhgk deleted the update-rspack branch December 21, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants