-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade rspack to 0.4.4 #352
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 32c9a00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
@@ -40,7 +40,7 @@ export async function rspackInitGenerator( | |||
} | |||
|
|||
if (schema.style === 'less') { | |||
devDependencies['@rspack/less-loader'] = rspackLessLoaderVersion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rspack/less-loader is deprecated and should use less-loader instead
b990470
to
60606ec
Compare
83adc8f
to
17965c7
Compare
|
It looks like |
It also looks like Nest is failing the e2e test. It cannot compile the decorator in I see something like this:
|
Thanks for your help! There is still a bug on Rspack side which breaks license-webpack-plugin, will ship the fix in 0.4.4, I will update the PR when it is released |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c974ef2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Ready for review! |
upgrade Rspack to 0.4.4, https://www.rspack.dev/blog/announcing-0.4.html#rspack-04-major-changes
This contains break change since
experiments.rspackFuture.disableTransformByDefault
is enabled by default in Rspack 0.4