This repository was archived by the owner on Jan 6, 2023. It is now read-only.
feat: ability to set no records , no filter results & filter input title text in UiTable #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(ui-table): added no records text , no filter results text and filter title property feat(ui-table): added ui-table tests
|
@skhanna10 It looks like this PR covers several new features. Could you update the title and add a description outline what all has been done? |
skhanna10
changed the title
skhanna10
changed the title
@mdeanjones : I have updated title & description , Please let me know if looks good now ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added “title” attribute to UiFilter input
feat: ability to set “noRecordsText” (text to display when zero records where passed to UiTable) in UiTable
feat: ability to set “noFiterResultsText” (text to display when zero records where found while filtering table ) in UiTable
feat: ability to set “filterTitle” (text to display user hover over filter input field ) in UiTable
feat: added UiTable tests