Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monthly update for NetCDF groups #155

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Monthly update for NetCDF groups #155

merged 7 commits into from
Sep 19, 2024

Conversation

trey-stafford
Copy link
Contributor

No description provided.

@trey-stafford trey-stafford changed the base branch from main to ecdr-at-25km September 19, 2024 01:05
@trey-stafford trey-stafford changed the title Monthly update for prototype groups Monthly update for NetCDF groups Sep 19, 2024
@trey-stafford
Copy link
Contributor Author

trey-stafford commented Sep 19, 2024 •
edited
Loading

Issue to de-duplicate some of the logic that's shared between publish_daily and publish_monthly. I made some progress in this PR, but focusing on getting something that works out now so that deadlines can me met.

@trey-stafford trey-stafford mentioned this pull request Sep 19, 2024
Open
@trey-stafford trey-stafford marked this pull request as ready for review September 19, 2024 14:53
sc0tts
sc0tts approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@sc0tts sc0tts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have the monthly variable names follow the same format as the daily 👍

@trey-stafford trey-stafford merged commit 3326841 into ecdr-at-25km Sep 19, 2024
1 check passed
@trey-stafford trey-stafford deleted the monthly-update-for-prototype-groups branch September 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0tts sc0tts sc0tts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trey-stafford @sc0tts