Clean up python version and add test structure #35
+186
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming with this we'll do unit tests on Travis and our integration tests on Circle CI? |
|
Thanks for cleaning up my initial experiments into using mypy by the way. 😄 |
willingc
force-pushed
the
version-cleanup
branch
from
1b2fa9f to
17c33b4
Compare
willingc
changed the title
|
@rgbkrk Ultimately was able to leave in versioneer by adjusting how travis sets up the environment for tests in python. |
|
Wahoo! Thank you @willingc! |
|
I'll do a review here and get this merged in soon so I can rebase the other PR. |
rgbkrk
reviewed
Jan 27, 2019
| LONG_VERSION_PY: dict = {} | ||
| HANDLERS: dict = {} | ||
| LONG_VERSION_PY = {} | ||
| HANDLERS = {} |
There was a problem hiding this comment.
I like that you added this file to the exceptions list and then removed my half-hearted attempt to semi type this.
rgbkrk
reviewed
Jan 27, 2019
| @@ -13,7 +15,7 @@ | |||
| https://github.com/pypa/sampleproject | |||
|
|
|||
| """ | |||
| from __future__ import print_function | |||
| # from __future__ import print_function | |||
There was a problem hiding this comment.
We can delete the extra comments here.
rgbkrk
reviewed
Jan 27, 2019
| @@ -3,6 +3,8 @@ | |||
| """" | |||
| setup.py | |||
|
|
|||
| bookstore may be installed on Python 3.6 or higher. | |||
|
|
|||
| Note: Do a version check for IPython. | |||
| IPython v6+ no longer supports Python 2. | |||
| If Python 2, install ipython 5.x. | |||
There was a problem hiding this comment.
We can delete this note too now. 😄
|
Thanks for all the structure for testing here. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.