Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a warning for gluing an object outside of a context #45

Merged
merged 7 commits into from
May 8, 2019
Merged

Added a warning for gluing an object outside of a context #45

merged 7 commits into from
May 8, 2019

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented May 1, 2019

Implements #42

@MSeal MSeal requested review from captainsafia and willingc May 1, 2019 18:16
@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #45 into master will decrease coverage by 1.89%.
The diff coverage is 62.5%.

@@           Coverage Diff            @@
##           master     #45     +/-   ##
========================================
- Coverage      96%   94.1%   -1.9%     
========================================
  Files           9      10      +1     
  Lines         400     424     +24     
========================================
+ Hits          384     399     +15     
- Misses         16      25      +9

@codecov
Copy link

codecov bot commented May 1, 2019 •
edited
Loading

Codecov Report

Merging #45 into master will decrease coverage by 0.03%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.04%     
==========================================
  Files           9       10       +1     
  Lines         400      421      +21     
==========================================
+ Hits          384      404      +20     
- Misses         16       17       +1

captainsafia
captainsafia approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Left a few comments inline.

scrapbook/utils.py Outdated Show resolved Hide resolved
scrapbook/tests/test_notebooks.py Outdated Show resolved Hide resolved
willingc
willingc reviewed May 2, 2019
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSeal Logically, this looks good. Let's revisit the naming a bit to avoid the double negative. Not sure that we want to encode behavior (no action) in to the name.

scrapbook/utils.py Outdated Show resolved Hide resolved
scrapbook/utils.py Outdated Show resolved Hide resolved
scrapbook/utils.py Outdated Show resolved Hide resolved
scrapbook/api.py Outdated Show resolved Hide resolved
scrapbook/api.py Outdated Show resolved Hide resolved
scrapbook/tests/test_notebooks.py Outdated Show resolved Hide resolved
scrapbook/tests/test_notebooks.py Outdated Show resolved Hide resolved
scrapbook/tests/test_scrapbooks.py Outdated Show resolved Hide resolved
scrapbook/tests/test_scrapbooks.py Outdated Show resolved Hide resolved
scrapbook/utils.py Outdated Show resolved Hide resolved
@MSeal
Copy link
Member Author

MSeal commented May 8, 2019

Test pass, but can't tell codecov to ignore the dropped by 0.04% coverage

willingc
willingc approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSeal. Looks great.

@willingc willingc merged commit 0d8d886 into nteract:master May 8, 2019
@MSeal MSeal deleted the kernelAware branch August 18, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSeal @captainsafia @willingc