-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEOS-1584: update halt on column for postgres to support auto mapping #2889
NEOS-1584: update halt on column for postgres to support auto mapping #2889
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
0fd05e4
to
f7cb45e
Compare
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 36.11% 36.03% -0.08%
==========================================
Files 322 322
Lines 36466 36716 +250
==========================================
+ Hits 13169 13232 +63
- Misses 21764 21942 +178
- Partials 1533 1542 +9 ☔ View full report in Codecov by Sentry. |
ef4b070
to
8c89673
Compare
@@ -1050,7 +1088,7 @@ type AiGenerateSourceTableOption struct { | |||
|
|||
func (s *PostgresSourceOptions) ToDto() *mgmtv1alpha1.PostgresSourceConnectionOptions { | |||
dto := &mgmtv1alpha1.PostgresSourceConnectionOptions{ | |||
HaltOnNewColumnAddition: s.HaltOnNewColumnAddition, | |||
// HaltOnNewColumnAddition: s.HaltOnNewColumnAddition, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
…that it can't map
c0317c0
to
324ffe5
Compare
TODO: