Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1584: update halt on column for postgres to support auto mapping #2889

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Oct 31, 2024

  • deprecated halt on new column add for Postgres only
  • for this field, it now auto converts it to the new halt strategy
  • Updates worker to handle this new situation
  • Updates frontend to also handle this new situation
  • Adds initial implementation for the auto map strategy in the worker prior to exposing it on the frontend. It is possible to configure this through our API now.

TODO:

  • follow up PR for updating the frontend to to allow specifying the different strategies

Copy link

linear bot commented Oct 31, 2024

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 6:44pm

@nickzelei nickzelei changed the title Nick/neos 1584 update halt on column for postgres to support auto mapping NEOS-1584: update halt on column for postgres to support auto mapping Oct 31, 2024
@nickzelei nickzelei added the enhancement New feature or request label Oct 31, 2024
@nickzelei nickzelei force-pushed the nick/neos-1584-update-halt-on-column-for-postgres-to-support-auto-mapping branch from 0fd05e4 to f7cb45e Compare October 31, 2024 21:11
Copy link

github-actions bot commented Oct 31, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (1)Nov 4, 2024, 6:44 PM

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 27.98507% with 193 lines in your changes missing coverage. Please review.

Project coverage is 36.03%. Comparing base (796419a) to head (3ede170).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ernal/benthos/benthos-builder/builders/sql-util.go 34.15% 129 Missing and 4 partials ⚠️
backend/sql/postgresql/models/models.go 0.00% 41 Missing and 4 partials ⚠️
internal/benthos/benthos-builder/builders/sql.go 23.07% 9 Missing and 1 partial ⚠️
backend/internal/auth/client/client.go 0.00% 4 Missing ⚠️
.../internal/auth/clientcred_token_provider/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
- Coverage   36.11%   36.03%   -0.08%     
==========================================
  Files         322      322              
  Lines       36466    36716     +250     
==========================================
+ Hits        13169    13232      +63     
- Misses      21764    21942     +178     
- Partials     1533     1542       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei force-pushed the nick/neos-1584-update-halt-on-column-for-postgres-to-support-auto-mapping branch 2 times, most recently from ef4b070 to 8c89673 Compare November 1, 2024 04:53
@nickzelei nickzelei marked this pull request as ready for review November 4, 2024 16:51
@@ -1050,7 +1088,7 @@ type AiGenerateSourceTableOption struct {

func (s *PostgresSourceOptions) ToDto() *mgmtv1alpha1.PostgresSourceConnectionOptions {
dto := &mgmtv1alpha1.PostgresSourceConnectionOptions{
HaltOnNewColumnAddition: s.HaltOnNewColumnAddition,
// HaltOnNewColumnAddition: s.HaltOnNewColumnAddition,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@nickzelei nickzelei force-pushed the nick/neos-1584-update-halt-on-column-for-postgres-to-support-auto-mapping branch from c0317c0 to 324ffe5 Compare November 4, 2024 18:38
@nickzelei nickzelei merged commit a074ac4 into main Nov 4, 2024
18 of 21 checks passed
@nickzelei nickzelei deleted the nick/neos-1584-update-halt-on-column-for-postgres-to-support-auto-mapping branch November 4, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants