Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEOS-1611: exposes neosync cloud option for worker, adds EE license to worker #2931

Merged
merged 2 commits into from
Nov 11, 2024
Merged

NEOS-1611: exposes neosync cloud option for worker, adds EE license to worker #2931

merged 2 commits into from
Nov 11, 2024

Conversation

nickzelei
Copy link
Member

No description provided.

@nickzelei nickzelei added the enhancement New feature or request label Nov 11, 2024
@linear Linear
Copy link

linear bot commented Nov 11, 2024

NEOS-1611 Wire up EE methods for Worker

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 11:03pm

@nickzelei nickzelei changed the title NEOS-1611: exposes neosync cloud option for worker NEOS-1611: exposes neosync cloud option for worker, adds EE license to worker Nov 11, 2024
alishakawaguchi
alishakawaguchi approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@alishakawaguchi alishakawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 35.90%. Comparing base (c78b5df) to head (f923584).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
worker/internal/cmds/worker/serve/serve.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2931       +/-   ##
===========================================
+ Coverage   13.13%   35.90%   +22.77%     
===========================================
  Files         326      326               
  Lines       37295    37319       +24     
===========================================
+ Hits         4897    13401     +8504     
+ Misses      31666    22373     -9293     
- Partials      732     1545      +813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 9fc27f6 into main Nov 11, 2024
10 of 11 checks passed
@nickzelei nickzelei deleted the nick/neos-1611-wire-up-ee-methods-for-worker branch November 11, 2024 23:19
@BrewTestBot BrewTestBot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alishakawaguchi alishakawaguchi alishakawaguchi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickzelei @alishakawaguchi