Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wraps temporal logger in slog.Logger for better system plugin #3000

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

nickzelei
Copy link
Member

Also updates a bunch of spots to use the testutil.GetLogger for tests

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 10:52pm

@nickzelei nickzelei added the Tech Debt Created by Linear-GitHub Sync label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.16%. Comparing base (ca71920) to head (5f72409).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
worker/internal/temporal-logger/logger.go 95.00% 2 Missing and 1 partial ⚠️
...atasync/activities/gen-benthos-configs/activity.go 0.00% 1 Missing ⚠️
...nc/activities/run-sql-init-table-stmts/activity.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3000       +/-   ##
===========================================
+ Coverage   24.93%   36.16%   +11.22%     
===========================================
  Files         343      344        +1     
  Lines       39323    39371       +48     
===========================================
+ Hits         9806    14239     +4433     
+ Misses      28549    23483     -5066     
- Partials      968     1649      +681     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review December 2, 2024 23:02
Copy link
Contributor

@alishakawaguchi alishakawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@nickzelei nickzelei merged commit 89961ee into main Dec 3, 2024
10 checks passed
@nickzelei nickzelei deleted the nick/temporal-slogger branch December 3, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants