Fixes foreign key statement bugs in postgres manager #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
- Coverage 23.48% 23.42% -0.07%
==========================================
Files 387 387
Lines 44474 44418 -56
==========================================
- Hits 10445 10404 -41
+ Misses 32970 32961 -9
+ Partials 1059 1053 -6 ☔ View full report in Codecov by Sentry. |
Benchstat Geomean Results0.95% sec/op, -0.04% B/op, 0.00% allocs/op Benchstat results |
nickzelei
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates postgres manager to create foreign key statements instead of using constraint definition from the database. These definitions are missing the schema in the definition causing problems.
Separates SQL to get foreign key statements and non foreign key statements. This makes it clear which columns are for which. Reduces complexity.
Updates non foreign key statements SQL to use higher level tables. Makes it easier to understand the query. Was unable to use higher level tables for the foreign key statements SQL because FK constraint names are not unique and caused duplicate issues with the reference columns.
Deprecates dead code. The first version of init statements. which were full create statements that included constraints.