Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop import-meta-resolve & es-main #488

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nobkd
Copy link
Collaborator

@nobkd nobkd commented Feb 18, 2025

This is currently WIP. Tests probably fail on jest too.

This will change the behavior of importing esbuild and lightningcss and probably other imported modules slightly, because they now have to be installed relative to the nuekit installation, and not in the nue project. If someone wants to have modules only for a specific project now, they'll also need the nuekit installation in the project itself. This is just a hunch, I'd have to check that more.

TODO:

  • drop es-main
  • drop import-meta-resolve
  • ignore jest peer dependency conflict on npm
  • check if resolve behavior is really different now for project js imports

@nobkd nobkd force-pushed the drop-import-meta-resolve+es-main branch from 89eb925 to 0422bde Compare February 18, 2025 22:05
@nobkd nobkd changed the title Drop import-meta-resolve & es-main Drop import-meta-resolve & es-main Feb 18, 2025
@nobkd nobkd force-pushed the drop-import-meta-resolve+es-main branch 3 times, most recently from b45d153 to fe7aa70 Compare February 20, 2025 17:24
@nobkd nobkd force-pushed the drop-import-meta-resolve+es-main branch from fe7aa70 to 851d17f Compare February 20, 2025 17:26
@tipiirai
Copy link
Contributor

Makes sense. I think we need to have the local installation option available anyway. Not everyone likes the global option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants