Fix test-driver output parsing crash on Ubuntu #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests on Ubuntu VMs, the
test-driver
can crash if the executed command callssudo
and writes tostderr
. For example:sudo
spawns a new TTY forstderr
on Ubuntu that gets read by thetest-driver
's output parsing. However, thetest-driver
only expects base64-encodedstdout
and fails whenstderr
data is read.stderr
usees/dev/ttyS0
)sudo
(notestderr
uses/dev/pts/0
)Because
stderr
is now read along with thestdout
, thetest-driver
's base64 decoding code crashes on unexpected data:A minimal reproducible example is provided in
am-on/nix-test-driver-ubuntu-bug.
Related issues:
(Worked on this during Thaiger sprint: Thaigersprint/thaigersprint-2025#1)