Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable to select some formatters without --allow-missing-formatter #278

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

nokazn
Copy link
Contributor

@nokazn nokazn commented Apr 5, 2024

Description

This PR changes checking missing formatters logic like the below.

  • If some formatters are specified with -f/--formatters, check whether they are defined in config and executable.
  • If not specified, check whether all formatters are executable

I think it will resolve #210.

If something goes wrong, feel free to point it out. Thank you.

@zimbatm zimbatm merged commit b802b97 into numtide:main Apr 6, 2024
18 checks passed
@zimbatm
Copy link
Member

zimbatm commented Apr 6, 2024

thanks!

@nokazn nokazn deleted the feature/#210/select-formatters branch April 6, 2024 12:25
@MangoIV
Copy link

MangoIV commented Apr 29, 2024

heya! this works for me and matches how I would expect it to work, however somehow this invalidates the cache; e.g.

@MangoIV
Copy link

MangoIV commented Apr 29, 2024

the issue is that my usecase is especially that b takes horrendously long, if it invalidates the cache to run the formatter without it, I can not use treefmt to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treefmt --formatters doesn't work correctly
3 participants