Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AB3 tutorials #31

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

teoks0199
Copy link

@teoks0199 teoks0199 commented Jul 22, 2024

Closes #22.

@damithc
Copy link

damithc commented Jul 26, 2024

@teoks0199 Check if image files need to be removed as well.
When writing the commit message, follow the guidelines given in https://se-education.org/guides/conventions/git.html

Copy link

@brein62 brein62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through the three deleted pages, the images that are no longer needed are all nicely organised and located in folders:

  • ./docs/images/add-remark
  • ./docs/images/remove
  • ./docs/images/tracing

There are several other images used in TracingCode.md but not located in ./docs/images/tracing. These are still used in the DG and cannot be deleted.

@teoks0199 teoks0199 force-pushed the remove-AB3-tutorials branch from d6cc4ce to 01cd07d Compare July 28, 2024 14:58
@teoks0199
Copy link
Author

Thanks @brein62 for identifying the images to be deleted, these images are indeed not used elsewhere. Prof @damithc, is it okay to remove all 26 png files located in those folders in one single commit?

@damithc
Copy link

damithc commented Jul 28, 2024

Thanks @brein62 for identifying the images to be deleted, these images are indeed not used elsewhere. Prof @damithc, is it okay to remove all 26 png files located in those folders in one single commit?

@teoks0199 Sure. In fact, the whole PR should be just one commit.

@teoks0199 teoks0199 force-pushed the remove-AB3-tutorials branch from 01cd07d to 92b398c Compare July 28, 2024 15:51
Copy link

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teoks0199 the commit message body exceeds the max width.
The description can be quite brief (i.e., as the tutorial has been moved to ..., let's remove it from here).

@teoks0199 teoks0199 force-pushed the remove-AB3-tutorials branch 4 times, most recently from 8d20c77 to fe34d22 Compare July 31, 2024 15:48
AB3 tutorials reside in the ./docs/tutorials folder.
Associated images are in ./docs/images/add-remark,
./docs/images/remove, and ./docs/images/tracing.

As the tutorials have been moved to
https://se-education.org/guides/tutorials/ab3.html,
let's remove them from this codebase.
@teoks0199 teoks0199 force-pushed the remove-AB3-tutorials branch from fe34d22 to 819b052 Compare July 31, 2024 15:49
@damithc damithc merged commit 885a5ab into nus-oss:master Aug 4, 2024
3 checks passed
@damithc
Copy link

damithc commented Aug 4, 2024

@teoks0199 Thanks for the PR. FYI, I shortened the commit message further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AB3 tutorials
3 participants