Skip to content

Conversation

Raraph84
Copy link

Adding support for Windows azerty oem keys (like <> key)
-> See here https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes

@s1hofmann
Copy link
Member

Hi @Raraph84 👋

thanks for opening this PR.
To be honest, I have mixed feelings about it.

Most of the introduced constants are already defined.
Since linbnut defaults to the US ANSI layout the respective constants are directly assigned to their keys.
Additionally, naming is very generic and Windows specific, which does not translate well to other platforms.

Docs state a clear mapping only for US ANSI, so what does oem_1 correspond to on e.g. a German ISO layout?

One thing I see is that for non-US-ANSI layouts a physical key is missing (OEM_102), I'll have to think about how to best integrate all physical keys.

But overall, I'd object to merge this PR for said reasons.

Best regards

Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants