Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests examples for nuxt/movies #83

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Added tests examples for nuxt/movies #83

wants to merge 58 commits into from
+6,467 −4,499

Conversation

Archetipo95
Copy link
Contributor

@Archetipo95 Archetipo95 commented Dec 17, 2024 •
edited
Loading

📚 Description

✨ Added

  • Implemented GitHub Actions for running end-to-end (e2e) tests.
  • Implemented GitHub Actions for running unit tests.
  • Added env.example file to provide a template for environment variables.
  • Added vitest.config.ts for Vitest configuration.
  • Exposed utility functions and mocks for unit tests, including environment utilities.
  • Added a simple example case for end-to-end (e2e) testing.
  • Added playwright.config.ts for Playwright configuration.
  • Added new dependencies:
    • @nuxt/test-utils
    • @playwright/test
    • @vitest/coverage-v8
    • @vitest/ui
    • @vue/test-utils
    • happy-dom
    • playwright-core
    • vitest
  • Added scripts for running tests and for fixing ESLint issues.
  • Added unit tests for composables.
  • Added component tests for:
    • components/video/Card.vue
    • components/photo/Modal.vue
    • components/photo/Card.vue
    • components/person/Photos.vue
    • components/person/Info.vue
    • components/person/Details.vue
    • components/person/CreditsList.vue
    • components/person/Credits.vue
    • components/person/Card.vue
    • components/StarsRate.vue

👌 Changed

  • Updated pnpm to latest [email protected].
  • Disabled Prettier and on-save formatting in VSCode settings.
  • Updated .gitignore to include additional files and directories.
  • 📖 Changed the title in the README.md file.
  • Changed a property type to optional in types.ts to reflect the updated code.
  • Updated dependencies:
    • @antfu/eslint-config
    • @nuxt/devtools
    • @nuxt/image
    • @unocss/nuxt
    • @vueuse/nuxt
    • eslint
    • nuxt
    • typescript
    • vue-tsc

🐞 Fixed

  • Fixed issues in composables/utils.ts identified by unit tests.

🧹 Chores

  • Fixed files with ESLint.

@Archetipo95
chore: using bun instead of pnpm
516f9f7
@Archetipo95
chore: updated some deps
1c614b0
@Archetipo95
fix: typecheck for translation classes in Modal.vue
add56df
@Archetipo95
feat: init tests
caf66dc
@Archetipo95
feat: init e2e tests
5521d9c
@Archetipo95
fix: linted files
336ef5d
@Archetipo95
chore: bumped bun version
8ae6f4d
@Archetipo95
chore: disabled prettier and linted files with eslint
13bbd04
@Archetipo95
feat: add CI for unit test
7f2179d
@Archetipo95
docs: update README to reflect testing integration
83a0004
@Archetipo95
fix: renamed correctly workflows folder
26d1cf6
@Archetipo95
Merge pull request #1 from Archetipo95/test
9e5701e 
docs: update README to reflect testing integration
@Archetipo95
chore: renamed test unit in unit tests
18b8559
@Archetipo95
feat: add caching for Bun dependencies in CI workflow
f725a3f
@Archetipo95
feat: add component tests
58c688a
@Archetipo95
feat: enable fail-fast strategy in CI workflows
e12b32c
@Archetipo95
feat: use frozen lockfile for Bun dependency installation in CI workf…
9152dbc 
…lows
@Archetipo95
feat: add browser configuration for Playwright tests with multiple de…
906d1b9 
…vices
@Archetipo95
fix: standardize workflow names to use consistent capitalization
678e988
@Archetipo95
feat: add Playwright test workflow with caching and fail-fast strategy
ef1f3d5
@Archetipo95
refactor: rename Playwright workflow to End-to-End Tests
5909e15
@Archetipo95
fix: rename workflow files for consistent naming convention
9967f0e
@Archetipo95
fix: update homepage test headings to reflect correct title
9f1c7ad
@Archetipo95
fix: update homepage test to check for correct heading text
b147842
@Archetipo95
fix: rename upload step for clarity in E2E tests workflow
91b6129
@Archetipo95
feat: add mock media and tests for media handling functions
f3fc445
@Archetipo95
refactor: remove component test configuration and update unit test in…
5737e01 
…cludes
@Archetipo95
fix: update test components to render with 'TestComponent' for clarity
70f9548
@Archetipo95
test: add unit tests for useRouteParam with mock route parameters
7cb3a8d
@Archetipo95
test: add unit tests for utility functions including formatDate, form…
52b7b6a 
…atTime, and formatVote
Archetipo95 and others added 21 commits December 9, 2024 14:19
@Archetipo95
test: add unit tests for Credits component and improve template data …
4658f82 
…attributes
@Archetipo95
test: add unit tests for CreditsList component and enhance template d…
acea4d4 
…ata attributes
@Archetipo95
test: add unit tests for Photos component and create mock data utilities
18b537f
@Archetipo95
test: refactor mockPerson function in Card component tests for improv…
5db5b13 
…ed clarity
@Archetipo95
test: refactor Credits component tests to use mock data utilities for…
f8d6e2e 
… improved clarity and maintainability
@Archetipo95
test: update helper function comments and replace createMockMedia wit…
2fd3b6d 
…h mockMedia in CreditsList tests for improved clarity
@Archetipo95
test: add unit tests for PersonInfo component and enhance template da…
44751c2 
…ta attributes for improved clarity
@Archetipo95
test: add unit tests for PersonDetails component and enhance template…
2948c72 
… data attributes for improved clarity
@Archetipo95
test: add coverage configuration for components and composables in Vi…
55110ad 
…test setup
@Archetipo95
test: update CreditsList tests to handle media items with optional ti…
2095ae9 
…tle and name properties
@Archetipo95
test: add unit test for personCard component to handle missing charac…
6372570 
…ter with known_for_department
@Archetipo95
test: update formatLang tests to handle unknown languages and specifi…
68f6bf5 
…c cases
@Archetipo95
test: refactor personCard tests to use dynamic base URL for image source
0cdd05c
@Archetipo95
test: add unit tests for PhotoCard component to verify image renderin…
0b0153d 
…g and button title
@Archetipo95
refactor: remove unused mockMedia function and update import path in …
0277c1c 
…tests
@Archetipo95
chore: update package dependencies and rename unit coverage script
ef9e69c
@Archetipo95 @NicholasAntidormi
test: add unit tests for PhotoModal component and improve accessibili…
055bbfe 
…ty with data-testid attributes

Co-authored-by: NicholasAntidormi <[email protected]>
@Archetipo95
feat: add mockVideo function
347a66c
@Archetipo95
test: add unit tests for Card component
73b6e7a
@Archetipo95
test: clean up and remove redundant comment in tests
88b234d
@Archetipo95
test: add unit tests for StarsRate component
93e6d26
danielroe
danielroe reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very exciting!

thank you for your work on this ❤️❤️❤️

.github/workflows/tests-e2e.yml Outdated Show resolved Hide resolved
danielroe
danielroe approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @antfu to confirm, but it looks great to me! (I tested locally as the CI won't run until it merges)

what a great resource ❤️

@danielroe danielroe requested a review from antfu December 18, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archetipo95 @danielroe