Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several fixes & improvements of C++ MonitorStage #2170

Merged
merged 10 commits into from
Feb 6, 2025
Merged

Several fixes & improvements of C++ MonitorStage #2170

merged 10 commits into from
Feb 6, 2025

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Feb 5, 2025 •
edited
Loading

Description

  • For some short-running pipelines, MonitorStage now ensures there's at least one line of progress bar output with throughput shown.
  • For pipelines need explicitly stopped with Ctrl+C, MonitorStage now ensures to output the progress bars again when the pipeline is completed, avoids the progress bars from being covered by other logs.
  • Using microseconds when calculating the throughput to avoid inf throughput
  • Each completed progress bar will turn into green with text [Completed]

Closes #2148

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added bug Something isn't working non-breaking Non-breaking change labels Feb 5, 2025
@yczhang-nv yczhang-nv self-assigned this Feb 5, 2025
@yczhang-nv yczhang-nv requested a review from a team as a code owner February 5, 2025 00:43
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
fix format
96a4b45
@yczhang-nv
Merge branch 'yuchen-fix-monitor-stage-one-log-line-issue' of github.…
e1afff9 
…com:yczhang-nv/Morpheus into yuchen-fix-monitor-stage-one-log-line-issue
@yczhang-nv
Copy link
Contributor Author

/ok to test

willkill07
willkill07 reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor feedback + suggestions. Nothing that should block the PR.

python/morpheus/morpheus/_lib/include/morpheus/controllers/monitor_controller.hpp Outdated Show resolved Hide resolved
python/morpheus/morpheus/_lib/include/morpheus/controllers/monitor_controller.hpp Show resolved Hide resolved
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2226afe into nv-morpheus:branch-25.06 Feb 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkill07 willkill07 willkill07 approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: MonitorStage ensure at least one log line
2 participants
@yczhang-nv @willkill07