Bugfix: Remove MORPHEUS_USE_CONDA option; Add warning if CONDA_PREFIX not found
#2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FIX` not found Signed-off-by: Will Killian <[email protected]>
willkill07
force-pushed
the
will-update-morpheus-conda
branch
from
efeb244 to
33887b9
Compare
dagardner-nv
reviewed
Feb 5, 2025
dagardner-nv
approved these changes
Feb 5, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2154
Description
MORPHEUS_USE_CONDACMake optionexternal/utilitiessubmoduleThis PR changes the configuration behavior slightly. If
CONDA_PREFIXis found, it will automatically configure to include looking for packages within conda. If not found, a WARNING message will be presented. Since conda is the preferred method for building Morpheus/MRC/etc, this was found to be a reasonable solution in discussion with David G.By Submitting this PR I confirm: