feat: add support for new LSP config API in Neovim 0.11+ #1475

umutondersu · 2025-04-16T17:39:11Z

Summary

Added support for the new LSP configuration API introduced in Neovim 0.11+
Maintains backward compatibility for Neovim 0.10 and below

ro0gr · 2025-04-17T10:28:39Z

Kickstart.nvim targets only the latest 'stable' and latest 'nightly' of Neovim.

Do we really need backward compatibility with Neovim 0 10? I'd consider going with a lighter, happy-path solution. Since the project mainly targets newcomers and servers educational purposes, they'd likely prefer to avoid dealing with legacy approaches.

umutondersu · 2025-04-17T11:08:05Z

I think that would be the right approach as well. The reason I intended to maintain backwards compatibility is that some parts of the code is still trying to maintain 0.10 like the client_supports_method. Depending on the others reaction I would also be in favor of removing it.

umutondersu · 2025-04-17T12:44:00Z

There is also the problem new syntax not supporting all lsp configs. For example tailwindcss requires the old setup. Could be a good idea to delay this until most lsp configs migrate.

nickgnd · 2025-04-17T13:18:51Z

Hey everyone 👋
I remember a few related conversations that happen lately on this topic, let me share them here

#1458
#1331

I hope they can be useful, cheers ✌️

init.lua

umutondersu · 2025-04-17T15:14:56Z

Hey everyone 👋 I remember a few related conversations that happen lately on this topic, let me share them here

#1458 #1331

I hope they can be useful, cheers ✌️

This setup config does not clash with blink.cmp so in that sense It should be okay.
I would be able to support this in an ongoing basis
I think using the native way would provide a better experience for newbies but that's up to debate

Signed-off-by: Umut Sahin Onder <[email protected]>

kaezrr · 2025-04-20T04:41:56Z

In my opinion, we shouldn't bother with backwards compatibility since Kickstart is mostly aimed at beginners who will download the latest version of Neovim as per the instructions in the repo readme

umutondersu · 2025-04-20T11:06:46Z

I have removed backwards compatibility and added useful comments for LSPs that still require the old setup

init.lua

umutondersu · 2025-04-24T10:18:55Z

Messing around with this and found that this will not respect the lsp_format = "fallback" option in the conform.nvim config. To replicate:
1. comment out the stylua formatter line from conform.nvim config

2. save and reload neovim

3. overindent a line or any other formatting change

4. write file
For me it did not fallback on the lua_ls server for formatting.

I couldn't replicate the issue. I do not think it would be related to these changes as conform.nvim does not use an LSP. In any case If you could check your conform logs by using :ConformInfo It could reveal more info about the issue.

init.lua

Co-authored-by: Rory Hendrickson <[email protected]>

- nvim-lua/kickstart.nvim#1475

1Naim · 2025-05-07T09:43:12Z

init.lua

        automatic_installation = false,
        handlers = {
          function(server_name)
-            local server = servers[server_name] or {}
-            -- This handles overriding only values explicitly passed
-            -- by the server configuration above. Useful when disabling
-            -- certain features of an LSP (for example, turning off formatting for ts_ls)
-            server.capabilities = vim.tbl_deep_extend('force', {}, capabilities, server.capabilities or {})
-            require('lspconfig')[server_name].setup(server)
+            local config = servers[server_name] or {}
+            vim.lsp.config(server_name, config)
+            vim.lsp.enable(server_name)
          end,


mason-lspconfig.nvim v2.0.0 removes this now. It auto-enables installed LSPs if they're using the new vim.lsp.* API. See https://github.com/mason-org/mason-lspconfig.nvim/releases/tag/v2.0.0

1Naim · 2025-05-07T09:58:53Z

init.lua

+        for server, config in pairs(servers) do
+          -- This handles overriding only values explicitly passed
+          -- by the server configuration above. Useful when disabling
+          -- certain features of an LSP (for example, turning off formatting for ts_ls)
+          config.capabilities = vim.tbl_deep_extend('force', {}, capabilities, server.capabilities or {})
+          vim.lsp.config(name, config)


I guess the original hunk of the patch is relevant (and should be used?) now.

Sorry I don't know how to mention lines, but shouldn't it be vim.lsp.config(server, config)? As well as vim.lsp.enable(server)

Yes that was fixed in a later commit in this PR, I was quoting from an earlier one.

pandar00 · 2025-05-10T08:28:29Z

AFAIK mason-lspconfig setting's handler is a no-op. (PR)
LSP settings are moved to after/lsp/<lang_server_name>.lua (credit; in JP)
lsp-config doc also explains the config is merged with the default.

Note: The merge semantics of configurations follow the behaviour of vim.tbl_deep_extend().

I've been updating my old neovim configs with the latest kickstart but the LSP settings weren't reflected in :LspInfo, but after following the above, LSP correctly reads them

umutondersu · 2025-05-10T17:09:12Z

AFAIK mason-lspconfig setting's handler is a no-op. (PR) LSP settings are moved to after/lsp/<lang_server_name>.lua (credit; in JP) lsp-config doc also explains the config is merged with the default.

Note: The merge semantics of configurations follow the behaviour of vim.tbl_deep_extend().

I've been updating my old neovim configs with the latest kickstart but the LSP settings weren't reflected in :LspInfo, but after following the above, LSP correctly reads them

If we were to move LSP configs to their own file, I don't know how mason-tool-installer would work without the servers table maybe by iterating over file names?

In your config I see that you still have the servers table. If It is still gonna be preset wouldn't be better to use vim.lsp.config with a loop (like my first hunk) rather than having 2 separate places for LSP servers?

umutondersu · 2025-05-10T17:13:46Z

As mentioned in previous conversations, Mason v2 has started introducing a significant delay during startup. For now, I’ve pinned the Mason version to avoid this issue.

From my testing, the problem appears to be related to mason-tool-installer; without it, I don’t experience any delays. It would be helpful to hear from someone with more insight into this before proceeding further with Mason v2.

shv187 · 2025-05-10T19:48:39Z

My personal temporary solution is to set debounce_hours in mason-tool-installer, to 24 in my case.

umutondersu added 2 commits April 16, 2025 19:34

feat: add support for new LSP config API in Neovim 0.11+

3f0cd75

Typo fix

f70dcb3

yetyetanotherusername reviewed Apr 17, 2025

View reviewed changes

init.lua Outdated Show resolved Hide resolved

init.lua Outdated Show resolved Hide resolved

umutondersu added 2 commits April 17, 2025 17:17

fix(lsp): correct variable name in lsp config loop

4b81900

Signed-off-by: Umut Sahin Onder <[email protected]>

style: format with stylua

5502cea

fix(lsp): Remove backwards compatibility and add comments for lsp setup

a590ab6

umutondersu added 2 commits April 20, 2025 13:12

fix: Typo in comment

dac395d

fix: revert back to original handler logic

531073d

1Naim reviewed Apr 22, 2025

View reviewed changes

init.lua Show resolved Hide resolved

yetyetanotherusername approved these changes Apr 23, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

roryhen reviewed Apr 27, 2025

View reviewed changes

init.lua Outdated Show resolved Hide resolved

oriori1703 mentioned this pull request Apr 29, 2025

Replace outdated require('lspconfig')[server_name].setup() #1502

Open

Fix: correct variables inside comments

81c5210

Co-authored-by: Rory Hendrickson <[email protected]>

michaellisitsa added a commit to michaellisitsa/dotfiles that referenced this pull request May 5, 2025

Use neovim v0.11 lsp capabilities

e917ad0

- nvim-lua/kickstart.nvim#1475

1Naim reviewed May 7, 2025

View reviewed changes

fix(deps): pin mason plugin versions to v1.*

9e0c7b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for new LSP config API in Neovim 0.11+ #1475

feat: add support for new LSP config API in Neovim 0.11+ #1475

umutondersu commented Apr 16, 2025 •

edited

Loading

ro0gr commented Apr 17, 2025

umutondersu commented Apr 17, 2025

umutondersu commented Apr 17, 2025

nickgnd commented Apr 17, 2025

umutondersu commented Apr 17, 2025

kaezrr commented Apr 20, 2025

umutondersu commented Apr 20, 2025

This comment was marked as resolved.

umutondersu commented Apr 24, 2025

This comment has been minimized.

1Naim May 7, 2025

1Naim May 7, 2025

shv187 May 8, 2025

1Naim May 9, 2025

pandar00 commented May 10, 2025 •

edited

Loading

umutondersu commented May 10, 2025

umutondersu commented May 10, 2025

shv187 commented May 10, 2025

feat: add support for new LSP config API in Neovim 0.11+ #1475

Are you sure you want to change the base?

feat: add support for new LSP config API in Neovim 0.11+ #1475

Conversation

umutondersu commented Apr 16, 2025 • edited Loading

Summary

ro0gr commented Apr 17, 2025

umutondersu commented Apr 17, 2025

umutondersu commented Apr 17, 2025

nickgnd commented Apr 17, 2025

umutondersu commented Apr 17, 2025

kaezrr commented Apr 20, 2025

umutondersu commented Apr 20, 2025

This comment was marked as resolved.

umutondersu commented Apr 24, 2025

This comment has been minimized.

1Naim May 7, 2025

Choose a reason for hiding this comment

1Naim May 7, 2025

Choose a reason for hiding this comment

shv187 May 8, 2025

Choose a reason for hiding this comment

1Naim May 9, 2025

Choose a reason for hiding this comment

pandar00 commented May 10, 2025 • edited Loading

umutondersu commented May 10, 2025

umutondersu commented May 10, 2025

shv187 commented May 10, 2025

umutondersu commented Apr 16, 2025 •

edited

Loading

pandar00 commented May 10, 2025 •

edited

Loading