fix unit test running #65
Conversation
There was a problem hiding this comment.
Great work, @jstensland! Thanks for contributing. All looks good, just left a minor comment
lua/spec/neotest-go/init_spec.lua
Outdated
| adapters = { | ||
| require("neotest-go")({ | ||
| experimental = { | ||
| test_table = true, |
There was a problem hiding this comment.
Probably we make it default on the future to not specify directly
lua/spec/neotest-go/init_spec.lua
Outdated
| @@ -33,6 +33,17 @@ assert:register( | |||
| "assertion.has_property.negative" | |||
| ) | |||
|
|
|||
| require("neotest").setup({ | |||
There was a problem hiding this comment.
What's the motivation for adding it?
There was a problem hiding this comment.
Tests were failing for me because I have different args set in my own config.
This seemed to fix the test expectations but also didn't overwrite them after I had run tests.
There was a problem hiding this comment.
Does it makes sense to put it to master if it's specific for you? 🤔
There was a problem hiding this comment.
It's not specific to me. It's specific to the test expectations. With no args specified in my own config, multiple tests fail. including
Fail || build_spec build specification for many_table_test.go
...re/nvim/site/pack/packer/start/neotest/lua/nio/tests.lua:27: Test task failed with message:
The coroutine failed with this message:
...ensla/repos/neotest-go/lua/spec/neotest-go/init_spec.lua:358: Expected objects to be the same.
Passed in:
(string) 'cd /Users/jstensla/repos/neotest-go/neotest_go && go test -v -json ./...'
Expected:
(string) 'cd /Users/jstensla/repos/neotest-go/neotest_go && go test -v -json -count=1 -timeout=60s ./...'
stack traceback:
[C]: in function 'error'
...e/pack/packer/start/plenary.nvim/lua/luassert/assert.lua:51: in function 'same'
...ensla/repos/neotest-go/lua/spec/neotest-go/init_spec.lua:358: in function <...ensla/repos/neotest-go/lua/spec/neotest-go/init_spec.lua:349>
stack traceback:
...re/nvim/site/pack/packer/start/neotest/lua/nio/tests.lua:27: in function <...re/nvim/site/pack/packer/start/neotest/lua/nio/tests.lua:12>
What I meant was that they also fail if I specify whatever I want for my configuration (I setup a coverage arg), but that's (somewhat) beside the point. I am guessing you have these args set for yourself if the tests pass without this setup in the test
There was a problem hiding this comment.
I have a doubts because we have already defined plugin on L3
There was a problem hiding this comment.
I see. I am open to suggestions on the best setup/teardown approach with Plenary's busted tests. This is my first time using them.
I switched to using the loaded plugin for setup
.luarc.json
Outdated
| "workspace.checkThirdParty": false, | ||
| "workspace.library": [ | ||
| "../neotest", |
There was a problem hiding this comment.
Running nvim --headless -c ':PlenaryBustedDirectory lua/spec' works for me without direct reference to those libraries. My understanding was that those dependencies are satisfied through plugin management.
There was a problem hiding this comment.
I was running this on new Ubuntu machine with a minimal config from here and it worked without workspace.library. I believe we can remove that piece
There was a problem hiding this comment.
Hapoy to remove if you like.
To clarify, it isn't needed for running the tests for me either, as those are loaded in my vim plugin. They were needed to make the LSP aware of those plugins so that it recognized the type annotations that reference neotest types, and then the plenary/busted functions.
| @@ -192,52 +203,52 @@ describe("discover_positions", function() | |||
| local positions = plugin.discover_positions(path):to_list() | |||
| local expected_positions = { | |||
| { | |||
| id = "/Users/sgetman/.local/share/nvim/site/pack/packer/start/neotest-go/neotest_go/map_table_test.go", | |||
| id = vim.loop.cwd() .. "/neotest_go/map_table_test.go", | |||
There was a problem hiding this comment.
Thanks for correcting paths! 👍
Changes
sgetmanuserNotes
I'm new to lua. Is there's a better way to get get plenary and neotest in the workspace? I don't love relying on them being adjacent to this repo. I added them as the LSP couldn't find the neotests types like
---@type neotest.Adapter, or plenary functions likeit