Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nw1 mode #7230

Open
rogerwang opened this issue Nov 22, 2019 · 9 comments
Open

Remove nw1 mode #7230

rogerwang opened this issue Nov 22, 2019 · 9 comments

Comments

@rogerwang
Copy link
Member

After nw2 mode released as default (#5875), it will get stablized in several major versions. Then the code for nw1 mode will be removed to save rebase effort. This issue is for tracking nw1 removal.

@rogerwang rogerwang pinned this issue Nov 22, 2019
@rogerwang
Copy link
Member Author

If anyone found their issue in nw2 and think it's blocking nw1 removal, please file an issue for nw2 and CC this issue.

@djcanard
Copy link

djcanard commented May 9, 2020

@rogerwang any idea in what timeframe nw1 mode will be removed? Weeks, or months?

@rogerwang
Copy link
Member Author

There is only #7361 which might be blocking NW1 removal. I'd say after 1-2 major version updates.

@TheRealDannyyy
Copy link

I think NW1 can be removed now.

My issue #7362 seems to be caused by Chrome's Win10 custom title bar implementation (which NW2 added support for).

@bastimeyer
Copy link

I think NW1 can be removed now.

There are still some issues like this one for example: #7488

@josh83abc
Copy link

Issues with evalNWBin, I always disable NW2 in my app for now #7547

@josh83abc
Copy link

josh83abc commented Oct 10, 2020

I just have added information Issues with evalNWBin #7547 but you closed it :'(

@peq42
Copy link

peq42 commented Dec 10, 2021

what is the current progress on the removal of NW1 mode @rogerwang ?

@Sunvas
Copy link

Sunvas commented Dec 11, 2023

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants