Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unregister device raw #1968

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: unregister device raw #1968

merged 2 commits into from
Jan 22, 2025

Conversation

zaneschepke
Copy link
Contributor

@zaneschepke zaneschepke commented Jan 21, 2025 •
edited by mmsinclair
Loading

This change is Reviewable

@rokas-ambrazevicius
Copy link
Contributor

We should be calling this on "logout"?

@zaneschepke
Copy link
Contributor Author

We should be calling this on "logout"?

I think it is correct to call this on forget account. This would mirror how it works on the other platforms.

@zaneschepke zaneschepke requested a review from octol January 21, 2025 22:28
octol
octol approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@zaneschepke zaneschepke merged commit 87d63ed into develop Jan 22, 2025
11 checks passed
@zaneschepke zaneschepke deleted the zane/device-removal-ios branch January 22, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokas-ambrazevicius rokas-ambrazevicius rokas-ambrazevicius approved these changes

@octol octol octol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaneschepke @rokas-ambrazevicius @octol