add blink cmp highlight groups #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blink seems to be fast taking over nvim-cmp as the defacto completion package. The cmdline functionality is very new and there seem to be few missing pieces that might require some adjustements later (ie Match and MachFuzzy for one). Without the new highlight groups blink will use either new lor legacy groups. The new groups look ok but are black and white. The legacy groups come up very bad looking. Also blink at least for now seems to be using the kind.property icon in the cmdline menu which seems different. I have therefore changed the color of only that icon in order to respect the cmdline.
Screenshots shown of completion with blink and these highlight groups.