Arrabbiata/witness: add field to accumulate challenges #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And keep also previous challenges that will be given as public input.
dannywillems
force-pushed
the
dw/add-accumulated-challenges
branch
from
7971ad0 to
6551807
Compare
dannywillems
commented
Feb 12, 2025
arrabbiata/src/witness.rs
Outdated
| @@ -142,6 +142,22 @@ pub struct Env< | |||
| pub challenges: Vec<BigInt>, | |||
|
|
|||
| /// Keep the current executed instruction | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dw/add-accumulated-witness #3020 +/- ##
=============================================================
Coverage ? 76.89%
=============================================================
Files ? 262
Lines ? 62140
Branches ? 0
=============================================================
Hits ? 47782
Misses ? 14358
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And keep also previous challenges that will be given as public input.