Arrabbiata: define Challenges structure #3022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
changed the title
dannywillems
force-pushed
the
dw/use-challenges-structure
branch
from
83db6e4 to
d29b294
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dw/add-accumulated-challenges #3022 +/- ##
================================================================
Coverage ? 76.87%
================================================================
Files ? 262
Lines ? 62165
Branches ? 0
================================================================
Hits ? 47787
Misses ? 14378
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dannywillems
commented
Feb 13, 2025
| /// Used by the accumulation protocol (folding) to perform a random linear | ||
| /// transformation of the witnesses and the public values. | ||
| /// Often noted `r` in the paper mentioning "folding protocols". | ||
| pub relation_randomiser: F, |
There was a problem hiding this comment.
Note that even though it is a challenge, it must be not accumulated by the accumulation scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be more explicit on the challenges the protocol defines. It will be easier in the code to refer to a particular name instead of an index. Also, we fix the number of challenges, hoping the structure will be linear in memory and we can enjoy the optimsiation of the CPU cache.