Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for this https://github.com/o1-labs/proof-systems/actions/runs/13273640255/job/37058646902?pr=2969
The problem comes from the time spent computing commitments for test iterations generating "large" user data. Using the
DataSize::Medium
and reducing to 10 test cases still gives good coverage.Medium
allows for larger than 1 chunk which is the most important thing here. On my machine this went from1min
to11s
, CI went back to the normal60min
range.While working on this I realized that while correct, the test was written awkwardly. I reordered the commitment checks to more closely match the lifecycle of the update