Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saffron] less punishing ci #3023

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Feb 12, 2025

Simple fix for this https://github.com/o1-labs/proof-systems/actions/runs/13273640255/job/37058646902?pr=2969

The problem comes from the time spent computing commitments for test iterations generating "large" user data. Using the DataSize::Medium and reducing to 10 test cases still gives good coverage. Medium allows for larger than 1 chunk which is the most important thing here. On my machine this went from 1min to 11s, CI went back to the normal 60min range.

While working on this I realized that while correct, the test was written awkwardly. I reordered the commitment checks to more closely match the lifecycle of the update

@martyall martyall marked this pull request as ready for review February 12, 2025 18:27
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (dca3c7f) to head (1569ce6).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3023      +/-   ##
==========================================
+ Coverage   76.87%   76.89%   +0.01%     
==========================================
  Files         262      262              
  Lines       62114    62118       +4     
==========================================
+ Hits        47752    47763      +11     
+ Misses      14362    14355       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the changes in the user input. I hope it unblocks the CI of other people.

@dannywillems dannywillems merged commit 4c055b2 into master Feb 13, 2025
13 checks passed
@dannywillems dannywillems deleted the martin/saffron-less-punishing-ci branch February 13, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants