Added RFC for Compute Shader support #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Material-related files. Signed-off-by: galibzon <[email protected]>
galibzon
requested review from
akioCL,
moudgils,
antonmic,
gadams3,
jhmueller-huawei,
martinwinter-huawei and
a team
galibzon
added a commit
to galibzon/o3de
that referenced
this pull request
Dec 3, 2024
to both *.MaterialPipelines and *.MaterialTypes This feature is important for alternative rendering methods like Texture/Object Space Shading that need to leverage the O3DE Material pipeline. The RFC is here: o3de/sig-graphics-audio#167 Please follow the RFC for details. Signed-off-by: galibzon <[email protected]>
kh-huawei
requested changes
Dec 5, 2024
There was a problem hiding this comment.
I generally support this RFC: having the option to use the Material-Shaders in a compute shader makes everything more flexible, and if we get nothing else, this is a good start.
But for this to be really useful, it would need to be a bit more flexible with the mip-level selection, and at least somehow support indirect dispatch.
And most features that would use this also need access to the geometry of multiple objects, but for that we also need RFC #152.
the SAMPLE_LEVEL_LOD macro for CS_SAMPLERS. Adjusted the RFC accordingly, and added remark that in the future we can provide more flexibility on whether using SampleLevel() or SampleGrad(). Signed-off-by: galibzon <[email protected]>
kh-huawei
approved these changes
Dec 9, 2024
moudgils
approved these changes
Dec 9, 2024
galibzon
added a commit
to o3de/o3de
that referenced
this pull request
Dec 10, 2024
* This commit adds support for Compute shaders to both *.MaterialPipelines and *.MaterialTypes This feature is important for alternative rendering methods like Texture/Object Space Shading that need to leverage the O3DE Material pipeline. The RFC is here: o3de/sig-graphics-audio#167 Please follow the RFC for details. Signed-off-by: galibzon <[email protected]>
DrogonMar
pushed a commit
to DrogonMar/o3de
that referenced
this pull request
Dec 20, 2024
* This commit adds support for Compute shaders to both *.MaterialPipelines and *.MaterialTypes This feature is important for alternative rendering methods like Texture/Object Space Shading that need to leverage the O3DE Material pipeline. The RFC is here: o3de/sig-graphics-audio#167 Please follow the RFC for details. Signed-off-by: galibzon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RFC for Compute Shader support