Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace onClick listeners with links #15

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Replace onClick listeners with links #15

merged 3 commits into from
Dec 6, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Nov 30, 2023

@csillag csillag requested a review from lubej November 30, 2023 23:38
Copy link
Contributor

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more location, that need to be replaced, here

window.open(METAMASK_HOME_PAGE, '_blank', 'noopener,noreferrer')

But otherwise looks good to me.

@lubej
Copy link
Contributor

lubej commented Dec 6, 2023

Also, can we get rid of underline:

image

@csillag
Copy link
Contributor Author

csillag commented Dec 6, 2023

There is one more location, that need to be replaced,

Fixed

@csillag
Copy link
Contributor Author

csillag commented Dec 6, 2023

Also, can we get rid of underline:

Fixed.

@csillag csillag marked this pull request as ready for review December 6, 2023 18:36
@csillag csillag merged commit 1516d58 into master Dec 6, 2023
2 checks passed
@csillag csillag deleted the csillag/use-links branch December 6, 2023 18:49
@lubej lubej mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants