Reduce visibility of gas and fee events #1531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
I am all for removing the event (to -> Fee accumulator). As other explorers don't show the event. For me it doesn't make sense as the event did not originate from the interacted contract - and it's duplicated as you have Gas Price row, which shows the value that you are interested in. |
lukaw3d
commented
Sep 12, 2024
Comment on lines
+24
to
+31
| const sortedEvents = events?.slice().sort((a, b) => { | ||
| // Attempt to sort gas/fee events to the bottom of a transaction. | ||
| // If events are paginated, it might not be at the end. | ||
| if (a.tx_hash === b.tx_hash) { | ||
| return (isGasFeeEvent(a) ? 1 : 0) - (isGasFeeEvent(b) ? 1 : 0) | ||
| } | ||
| return 0 | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion. At some point we also discussed removing these two gas events.
https://explorer.dev.oasis.io/testnet/sapphire/tx/0x5ab245233b9f467f55d8dba437a59fac7c9abd91b0e5cec0312686f4a87c07f5
