Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for transaction gas price explanation #1533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Sep 10, 2024

No description provided.

Copy link

github-actions bot commented Sep 10, 2024

Deployed to Cloudflare Pages

Latest commit: be9df7df1da2f02fd6626a346e0f942eb98332ec
Status:✅ Deploy successful!
Preview URL: https://e6ac87d9.oasis-explorer.pages.dev

@lubej lubej force-pushed the ml/tx-gas-price-explanation branch from 0c6fa5a to be9df7d Compare September 10, 2024 20:31
@lubej lubej marked this pull request as ready for review September 11, 2024 04:30
@@ -459,7 +459,8 @@
"txEncrypted": "This transaction is encrypted.",
"txNotEncrypted": "This transaction is <strong>not</strong> encrypted.",
"senderTooltipUnavailable": "Sender not available in selected address format",
"recipientTooltipUnavailable": "Recipient not available in selected address format"
"recipientTooltipUnavailable": "Recipient not available in selected address format",
"gasPriceExplanation": "For each transaction, you're charged a certain amount for the gas you use and is measured in nano ROSE(Gwei)."
Copy link
Contributor

@buberdds buberdds Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ...measured in nano {{ ticker }}

Why we say it is gwei? nanoROSE (or whatever will be used here nEUROe etc) and GWEI are not interchangeable or equal.

@lubej lubej self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants