Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon.svg to be compatible with darkmode #1566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CedarMist
Copy link
Member

Uses same icon as from docs.oasis.io

Uses same icon as from docs.oasis.io
@CedarMist CedarMist added the ux/design UX/UI Design Change Report label Oct 8, 2024
@CedarMist CedarMist self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Deployed to Cloudflare Pages

Latest commit: f0648fb6ed87b55f1468fc04666980516ccdd307
Status:✅ Deploy successful!
Preview URL: https://db5ebe12.oasis-explorer.pages.dev
Alias: https://pr-1566.oasis-explorer.pages.dev

@buberdds
Copy link
Contributor

buberdds commented Oct 8, 2024

hm this update should go other way around. Docs is not using the correct favicon. The new one was introduced during rebrand and is used by all other products. I am not UI or brand designer so I will leave decision to @donouwens who created favicon.

@CedarMist
Copy link
Member Author

CedarMist commented Oct 8, 2024

iirc the updated favicon from @donouwens was to make it work in dark mode by adding a white background because the blue color was contrasting really badly in dark mode. However, this made the favicon much smaller and more difficult to discern amongst other favicons, and makes the detail of the Oasis logo blurry and harder to see.

This updated favicon works in light mode (with the brand blue color) and dark mode (by turning white), while retaining the detail of the icon and has a size equivalent to the majority of favicons on the web.

image

@tjanez
Copy link
Member

tjanez commented Dec 13, 2024

iirc the updated favicon from @donouwens was to make it work in dark mode by adding a white background because the blue color was contrasting really badly in dark mode. However, this made the favicon much smaller and more difficult to discern amongst other favicons, and makes the detail of the Oasis logo blurry and harder to see.

Agreed. Having a smaller Oasis logo because of white background makes the favicon harder to see and doesn't look well compared to favicons of other sites.

This updated favicon works in light mode (with the brand blue color) and dark mode (by turning white), while retaining the detail of the icon and has a size equivalent to the majority of favicons on the web.

Agreed regarding light mode. However, in the dark mode, the icon didn't turn to white for me on Chromium or Firefox:
Screenshot from 2024-12-13 09-31-01 (Copy)
Screenshot from 2024-12-13 09-32-31 (Copy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/design UX/UI Design Change Report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants