Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rofl: Fix support for Instance Registered event #922

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

gw0
Copy link
Contributor

@gw0 gw0 commented Mar 5, 2025

The Nexus Sapphire Testnet analyzer got stuck at processing block 10653792 that includes the new recently added InstanceRegisteredEvent (oasisprotocol/oasis-sdk#2159). This PR adds support for decoding such events that was missing in #917.

{"analyzer":"sapphire","caller":"block.go:412","height":10653792,"level":"info","mode":"slow-sync","module":"analysis_service","msg":"processing block","ts":"2025-03-05T18:00:43.160965827Z"}
{"analyzer":"sapphire","caller":"block.go:425","err":"extract non-tx events: event 6: decode rofl: invalid rofl event code: 4; raw event: {Module:rofl Code:4 Value:[129 162 99 114 97 107 161 103 101 100 50 53 53 49 57 88 32 22 23 122 67 18 40 176 86 9 150 65 237 63 79 58 186 10 247 12 51 163 118 159 50 118 57 28 89 227 17 215 75 102 97 112 112 95 105 100 85 0 215 149 192 51 251 75 148 135 61 129 182 50 127 83 113 118 143 252 111 207] TxHash:41ba7d12683a75b590f72e33b16c9979d92ce9a3d5caf4c177e36e885b432dcb}","height":10653792,"level":"error","mode":"slow-sync","module":"analysis_service","msg":"error processing block","ts":"2025-03-05T18:00:43.161497176Z"}

After applying this hotfix the Nexus Sapphire Testnet analyzer works again.

@gw0 gw0 self-assigned this Mar 5, 2025
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh i guess missed this in #917

@gw0 gw0 force-pushed the gw0/fix-rofl-apps-instanceregistered branch from c8a168a to 6907888 Compare March 6, 2025 08:48
@gw0 gw0 merged commit 053ee09 into main Mar 6, 2025
16 checks passed
@gw0 gw0 deleted the gw0/fix-rofl-apps-instanceregistered branch March 6, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants