Fix observer role registration #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
kostko
reviewed
Feb 4, 2025
abukosek
force-pushed
the
andrej/fix/observer-reg
branch
4 times, most recently
from
cc55958 to
64d1512
Compare
kostko
reviewed
Feb 4, 2025
abukosek
force-pushed
the
andrej/fix/observer-reg
branch
from
64d1512 to
b9ba874
Compare
abukosek
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
|
OK, this should work now, please re-review :) |
peternose
reviewed
Feb 4, 2025
kostko
reviewed
Feb 5, 2025
abukosek
force-pushed
the
andrej/fix/observer-reg
branch
2 times, most recently
from
1fb5f44 to
1c34f91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6037 +/- ##
==========================================
- Coverage 65.57% 65.16% -0.42%
==========================================
Files 635 635
Lines 64600 64610 +10
==========================================
- Hits 42362 42103 -259
- Misses 17378 17577 +199
- Partials 4860 4930 +70 ☔ View full report in Codecov by Sentry. |
kostko
reviewed
Feb 5, 2025
abukosek
force-pushed
the
andrej/fix/observer-reg
branch
from
1c34f91 to
3e602b4
Compare
abukosek
force-pushed
the
andrej/fix/observer-reg
branch
from
3e602b4 to
ec5fb33
Compare
peternose
reviewed
Feb 6, 2025
peternose
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6019.