unbreak paratime withdraw #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
requested review from
kostko,
lukaw3d,
peterjgilbert and
tjanez
as code owners
pro-wh
force-pushed
the
pro-wh/feature/minprice10
branch
from
a91caaf to
e0c9819
Compare
pro-wh
commented
Jan 20, 2022
|
tried on testnet and the balances seem roughly right, but oasisscan isn't indexing the transactions |
pro-wh
force-pushed
the
pro-wh/feature/minprice10
branch
from
e0c9819 to
5b3e398
Compare
|
reduced paratime withdraw/deposit gas to 15k (from 50k) added changelog |
nhynes
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
This should do. One suggestion though: add a popup that says "submit this transaction anyway" instead of forcing people to accept the local sanity check. That local check introduces a huge dependency on Oasisscan (or other indexer) and prevents people from moving their funds.
nhynes
reviewed
Jan 21, 2022
|
filed #233 for the "submit anyway" idea, thanks for the suggestion |
tjanez
approved these changes
Jan 21, 2022
|
ya sure |
The fee entry UI specifically deals with nano (1e-9) units, not base units. In paratimes that have decimals != 9, this produced the wrong gas amount.
The fee amount is the total fee. We shouldn't multiply it by the gas.
|
oh some of the later commits don't even have changelog entries. I'll add those too |
An upcoming change to Emerald will require a minimum gas price.
An estimate from the SDK CLI indicated that it was ~11287 gas.
pro-wh
force-pushed
the
pro-wh/feature/minprice10
branch
from
abde87e to
2691cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed upcoming changes to Emerald will require a minimum gas price, which will make zero-fee withdrawal stop working
this is a minimal patch to use a hardcoded value for a withdrawal fee (that being the only non-deposit paratime transaction supported). we're interested in querying the minimum gas price in a larger change #227
reviewers, be on your guard. I don't know if I'm right about these changes