Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signing #11

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Implement signing #11

merged 11 commits into from
Mar 19, 2024

Conversation

vhf
Copy link
Contributor

@vhf vhf commented Mar 15, 2024

  • document
  • improve hmac-drbg
  • improve tests (in particular, test signing and then verifying)
  • sign with privkey+passphrase can be implemented later

@vhf vhf force-pushed the feat/sign branch 3 times, most recently from fd78f34 to b37ecaf Compare March 15, 2024 13:15
@vhf vhf force-pushed the feat/sign branch 2 times, most recently from 9c87a35 to a039c22 Compare March 17, 2024 17:23
@vhf vhf force-pushed the feat/sign branch 3 times, most recently from 7674054 to dbb01bb Compare March 18, 2024 14:43
@vhf vhf marked this pull request as ready for review March 18, 2024 15:02
@vhf vhf requested a review from Awea March 18, 2024 15:03
Copy link
Contributor

@Awea Awea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@vhf vhf merged commit 29cfb8c into main Mar 19, 2024
1 check passed
@vhf vhf deleted the feat/sign branch March 19, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants