Skip to content

Commit

Permalink
test:tsc in CI (#1865)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbostock authored Sep 20, 2023
1 parent 0f9e3af commit 61d8a74
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches: [main]

jobs:
build:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -16,11 +16,12 @@ jobs:
node-version: 16
cache: 'yarn'
- run: yarn --frozen-lockfile
- run: yarn test:mocha
- run: yarn test:tsc
- run: |
echo ::add-matcher::.github/eslint.json
yarn run eslint src test --format=compact
- run: yarn run prettier --check src test
- run: yarn test:mocha
- run: yarn test:prettier
- run: yarn prepublishOnly
- run: yarn docs:build
- uses: actions/upload-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion src/transforms/bin.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export type BinYInputs<T> = Omit<T, "y"> & {y?: ChannelValueBinSpec} & BinOption
export type BinInputs<T> = Omit<T, "x" | "y"> & {x?: ChannelValueBinSpec; y?: ChannelValueBinSpec} & BinOptions;

/** Output channels (and options) for the bin transform. */
export type BinOutputs = ChannelReducers<BinReducer> & GroupOutputOptions<BinReducer> & BinOptions;
export type BinOutputs = ChannelReducers<BinReducer> | (GroupOutputOptions<BinReducer> & BinOptions);

/**
* Bins on the **x** channel; then subdivides bins on the first channel of
Expand Down
2 changes: 1 addition & 1 deletion src/transforms/group.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface GroupOutputOptions<T = Reducer> {
}

/** Output channels (and options) for the group transform. */
export type GroupOutputs = ChannelReducers & GroupOutputOptions;
export type GroupOutputs = ChannelReducers | GroupOutputOptions;

/**
* Groups on the first channel of **z**, **fill**, or **stroke**, if any, and
Expand Down

0 comments on commit 61d8a74

Please sign in to comment.