Fix the Skolem trick with GHC ≥ 9.4 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncfavier Can you add back the removed tests to "prove it"? |
ncfavier
force-pushed
the
fix-skolem-trick
branch
from
aa17639 to
91ae597
Compare
|
Sorry I was really unclear --- add the skipped-over GHC versions (in the cabal file and github actions) to prove it works on them too. |
ncfavier
force-pushed
the
fix-skolem-trick
branch
from
91ae597 to
4039a28
Compare
|
This should do it, if there's anything else feel free to push directly to this branch. |
|
Now there are failures in the older versions? Do we need to conditionally switch between type and data family? |
Using a data family instead of a type family weirdly prevents the `Skolem` constructor from being treated as a metavariable, see https://gitlab.haskell.org/ghc/ghc/-/issues/23743#note_522186
ncfavier
force-pushed
the
fix-skolem-trick
branch
from
4039a28 to
6614029
Compare
|
No I was just confused and undid the wrong thing. |
sorki
added a commit
to haskell-nix/hnix-store
that referenced
this pull request
Dec 2, 2023
until obsidiansystems/dependent-sum-template#7 and its next release.
sorki
added a commit
to haskell-nix/hnix-store
that referenced
this pull request
Dec 3, 2023
until obsidiansystems/dependent-sum-template#7 and its next release.
|
(This should be good to go.) |
sorki
added a commit
to haskell-nix/hnix-store
that referenced
this pull request
Dec 6, 2023
until obsidiansystems/dependent-sum-template#7 and its next release.
|
Published: https://hackage.haskell.org/package/dependent-sum-template-0.2.0.1 Thanks again @ncfavier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a data family instead of a type family weirdly prevents the
Skolemconstructor from being treated as a metavariable, see https://gitlab.haskell.org/ghc/ghc/-/issues/23743#note_522186Backlog: #2 (comment)
@ali-abrar @cgibbard