Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-filters: Add white balance filter #11850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mar10iana
Copy link
Contributor

Description

This PR introduces a new White Balance Filter for OBS Studio by adding white_balance_filter.c and white_balance_filter.effect.

This filter allows users to fine-tune red, green, and blue balance using three sliders. It applies a color transformation matrix to adjust white balance dynamically for more accurate color correction.

Captura de ecrã 2025-02-09, às 17 54 28 Captura de ecrã 2025-02-09, às 17 54 49

The filter consists of:

  • C implementation (white_balance_filter.c)

    • Registers a new filter with three adjustable sliders.
    • Applies a color matrix transformation based on user input.
  • Shader effect (white_balance_filter.effect)

    • Applies the color matrix correction in the pixel shader.

Motivation and Context

Currently, OBS offers a variety of color correction filters but lacks a dedicated white balance feature, which is essential for many users. This feature aims to address this issue by introducing a White Balance option in the Filter menu.

Ideas website link: White Balance Feature Request

How Has This Been Tested?

  • Platform: macOS
  • Steps to Test:
    1. Add a new Filter to a source.
    2. Select White Balance Filter.
    3. Adjust the Red, Green, and Blue sliders.
    4. Observe real-time color correction.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This commit adds `white-balance-filter.c` and
`white_balance_filter.effect`, introducing a white balance
filter in OBS Studio.

Handles user input with three sliders and applies a white
balance transformation matrix to adjust red, green, and
blue levels for accurate color correction.
@mar10iana
Copy link
Contributor Author

Hey @Warchamp7, can you review this version of the white balance filter please?
I am sorry for making a new PR.

@WizardCM WizardCM added New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements. labels Feb 9, 2025
@obsproject obsproject deleted a comment from hung12330 Feb 10, 2025
@Warchamp7 Warchamp7 self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants