Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requesthandler: Add optional context to TriggerHotkeyByName #1187

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Dec 3, 2023

Description

Add optional context to TriggerHotkeyByName

Motivation and Context

The same hotkey name can exist on multiple context, to make sure we got the correct one add an optional context

How Has This Been Tested?

Tried calling
{ "requestType": "TriggerHotkeyByName", "requestData": { "hotkeyName": "OBSBasic.SelectScene", "contextName": "Scene 1" } }
Tested OS(s): Windows 11

Types of changes

  • New request/event (non-breaking)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

src/requesthandler/RequestHandler_General.cpp Outdated Show resolved Hide resolved
src/utils/Obs_SearchHelper.cpp Show resolved Hide resolved
src/utils/Obs_SearchHelper.cpp Outdated Show resolved Hide resolved
src/utils/Obs_SearchHelper.cpp Outdated Show resolved Hide resolved
@exeldro exeldro force-pushed the TriggerHotkeyByName_context branch from ee2e24e to b75807b Compare January 9, 2024 06:24
@exeldro exeldro requested a review from tt2468 January 9, 2024 06:46
@tt2468 tt2468 merged commit f43ef8e into obsproject:master Jan 9, 2024
1 check passed
@exeldro exeldro deleted the TriggerHotkeyByName_context branch January 9, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants