Add reproduction for some locate issues #1930
Conversation
|
@ddickstein I added reproduction for the issues you listed when they were missing. |
| @@ -5408,7 +5408,7 @@ and type_label_exp create env loc ty_expected | |||
| if is_poly then check_univars env "field value" arg label.lbl_arg vars; | |||
| (lid, label, {arg with exp_type = instance arg.exp_type}) | |||
|
|
|||
| and type_argument ?explanation ?recarg env sarg ty_expected' ty_expected = | |||
| and type_argument_ ?explanation ?recarg env sarg ty_expected' ty_expected = | |||
There was a problem hiding this comment.
what is the difference between type_argument and type_argument_ ? could we find more meaningful names?
And it looks strange that we touch to something inside src/ocaml/typing? Is this related to type recovery?
There was a problem hiding this comment.
Oh ok! In fact type_argument_ is the OCaml one and type_argument is a wrapper dealing with Merlin specific stuff? Make sense.
There was a problem hiding this comment.
Exactly. The same pattern is used for type_expect (or something similar)
| set_levels saved; | ||
| let loc = sarg.pexp_loc in | ||
| { | ||
| exp_desc = Texp_ident |
There was a problem hiding this comment.
WDYT about extracting the exp_desc in a dedicated variable?
locate-typebrings me to wrong type #1594 is due to Dune not generating configuration force the source of a copied fileThe last commit should fix both #1580 and #1588.