Skip to content

Add tests for outline generation in .mli #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

Tim-ats-d
Copy link
Contributor

cc @voodoos
cc @xvw

@Tim-ats-d Tim-ats-d force-pushed the mli-outline branch 3 times, most recently from a80f006 to 5ac62bd Compare May 7, 2025 14:30
@Tim-ats-d
Copy link
Contributor Author

So the generation of outline in .mli is not broken, I have only forgotten to pass -filename foo.mli.

Maybe I can squatch my two commits and rename this PR?

@xvw xvw added the no changelog Turn off CI changelog-check label May 7, 2025
@xvw
Copy link
Collaborator

xvw commented May 7, 2025

Yes, you can have only one commit. I'll try to review it to propose a mapping model from Merlin to LSP.

@Tim-ats-d
Copy link
Contributor Author

I have squashed them

Copy link
Collaborator

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have more tests !

@voodoos voodoos added this to the 5.5 milestone May 20, 2025
@voodoos voodoos merged commit 3865a38 into ocaml:main May 20, 2025
4 of 5 checks passed
@Tim-ats-d Tim-ats-d deleted the mli-outline branch May 23, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Turn off CI changelog-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants