Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to js_of_ocaml 6.0 #808

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adapt to js_of_ocaml 6.0 #808

wants to merge 4 commits into from
+52 −63

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented Nov 27, 2024 •
edited by hhugo
Loading

@vouillon vouillon marked this pull request as draft November 27, 2024 14:14
@vouillon vouillon changed the title Scroll positions are now floats Adapt to Dom_html changes Dec 13, 2024
@hhugo hhugo mentioned this pull request Mar 4, 2025
Open
@hhugo hhugo force-pushed the scroll-position branch from 60fbfc8 to 2059328 Compare March 5, 2025 14:55
@hhugo hhugo marked this pull request as ready for review March 5, 2025 14:55
@hhugo hhugo changed the title Adapt to Dom_html changes Adapt to js_of_ocaml 6.0 Mar 5, 2025
@hhugo hhugo requested a review from balat March 5, 2025 16:03
@hhugo hhugo force-pushed the scroll-position branch from a283867 to 633d960 Compare March 5, 2025 16:21
@balat
Copy link
Member

balat commented Mar 5, 2025

Do we need other changes (in Ocsigen Toolkit/Start?) before merging this?

@hhugo
Copy link
Member

hhugo commented Mar 5, 2025

Do we need other changes (in Ocsigen Toolkit/Start?) before merging this?

@vouillon might know

@hhugo
Copy link
Member

hhugo commented Mar 5, 2025

I've dropped the fix for OCaml 5.3 from this PR

@hhugo
Copy link
Member

hhugo commented Mar 5, 2025

There is ocsigen/ocsigen-toolkit#235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balat balat balat approved these changes

Assignees

@vouillon vouillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vouillon @balat @hhugo