Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-flat-float-array does not support non-x86_64 or arm64 platforms with OCaml >= 5.0 #53

Closed
wants to merge 1 commit into from
Closed

no-flat-float-array does not support non-x86_64 or arm64 platforms with OCaml >= 5.0 #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ocaml_version.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ let trunk_variants (arch:arch) =
if arch = `X86_64 || arch = `Aarch64 then
[[]; [`Afl]; [`Flambda]; [`Disable_flat_float_array]]
else
[[]; [`Disable_flat_float_array]]
[]
in
(* Frame pointers aren't currently supported on trunk *)
let _arch_opts =
Expand Down Expand Up @@ -507,7 +507,8 @@ let compiler_variants arch ({major; minor; _} as t) =
variants in
(* +no-flat-float-array for OCaml 4.12+ *)
let variants =
if version >= (4, 12) then
if (version >= (5, 0) && (arch = `X86_64 || arch = `Aarch64))
|| (version >= (4, 12) && version < (5, 0)) then
[`Disable_flat_float_array] :: variants
else
variants in
Expand Down