Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code comment on Releases module inline with implementation. #63

Merged
merged 1 commit into from
May 15, 2023

Conversation

tmcgilchrist
Copy link
Member

Update code comment on Releases module inline with implementation. Not sure whether this was intended but the code comment and implementation of these functions differs.
In opam-repo-ci and to a lesser extent ocaml-ci we rely on this implementation for checking supported OCaml versions.

Update code comment on Releases module inline with implementation.
Copy link
Contributor

@MisterDA MisterDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MisterDA MisterDA merged commit 32911fe into master May 15, 2023
@MisterDA MisterDA deleted the tmcgilchrist-releases branch May 15, 2023 12:28
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Sep 17, 2023
CHANGES:

 * OCaml 5.1.0 update (@Octachron ocurrent/ocaml-version#65)
 * Update code comment on Releases module inline with implementation. (@tmcgilchrist ocurrent/ocaml-version#63)
 * Put 5.1.0 in beta state and add 5.2.0 (trunk) (@kit-ty-kate ocurrent/ocaml-version#62)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

 * OCaml 5.1.0 update (@Octachron ocurrent/ocaml-version#65)
 * Update code comment on Releases module inline with implementation. (@tmcgilchrist ocurrent/ocaml-version#63)
 * Put 5.1.0 in beta state and add 5.2.0 (trunk) (@kit-ty-kate ocurrent/ocaml-version#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants