-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[IMP] pos/viva: Update Viva.com doc #13848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
task-4745855
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @emmi-odoo for this PR! I added a few comments and suggestion, including one about restructuring the configuration part of the doc. Let me know if you'd like to discuss it!
Connecting a **Viva.com** :doc:`payment terminal <../terminals>` gives customers a fluid payment | ||
flow and eases cashiers' work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to the Viva.com website? (like we do for payment providers) And I think I would replace this sentence as it sounds too marketing-y and does add much value IMO.
Also, I see there are many different Viva.com payment terminals (and an app for the Tap to Pay option), are all of them supported/covered in this documentation? Are there configuration differences? Should we mention these options (briefly) here (and mention they need/don't need specific configurations)? What do you think?
- Many European countries support the use of Viva.com payment terminals. Check the `availability | ||
of the Viva Terminal app in Europe <https://developer.viva.com/about-viva/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Many European countries support the use of Viva.com payment terminals. Check the `availability | |
of the Viva Terminal app in Europe <https://developer.viva.com/about-viva/>`_. | |
- `Many European countries <https://developer.viva.com/about-viva/>`_ support the use of Viva.com payment terminals. |
|
||
.. note:: | ||
Viva.com lets you turn your phone into a mobile card reader: `Tap On Phone | ||
Viva.com turns phones into card readers with `tapping options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viva.com turns phones into card readers with `tapping options | |
Viva.com allows you to `turn your phone into a mobile card terminal |
(borrowed this from viva.com's website; i think its more accurate. And FYI, I think this feature is more commonly called "Tap to Pay")
|
||
.. note:: | ||
Viva.com lets you turn your phone into a mobile card reader: `Tap On Phone | ||
Viva.com turns phones into card readers with `tapping options | ||
<https://www.viva.com/en-gb/blog/tap-on-phone-turn-your-phone-into-a-mobile-card-reader>`_. | ||
|
||
Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the only h2 on this doc page, I suggest removing it entirely.
That being said, I think it'd be easier to split the configuration section of this doc into 1) all viva.com configurations (use "save for later when necessary) and 2) all Odoo PoS configurations instead of going back and forth between viva.com and Odoo all the time for the different configurations.
See the payment providers doc (e.g;, Xendit or Razorpay) for an example of what I mean (I would not use the same headings but something more like "Viva.com configuration" and "Odoo PoS configuration" or something similar.
I also strongly suggest testing the account creation part on viva.com (I haven't checked yet, my apologies if you have already!)
(We can of course discuss this 😉 )
task-4745855