[IMP] TopBar: Add responsiveness #5647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
master-responsive-rar
branch
2 times, most recently
from
e2ad9aa to
5fa420b
Compare
rrahir
force-pushed
the
master-responsive-rar
branch
8 times, most recently
from
7e3b1c9 to
a746e32
Compare
rrahir
force-pushed
the
master-responsive-rar
branch
from
a746e32 to
24ead17
Compare
rrahir
force-pushed
the
master-responsive-rar
branch
from
24ead17 to
53d8940
Compare
The current top bar does not behave well on narrow screens, the top bar composer will disappear and the whole layout will become scrollable because of it. Past the composer, the toolbox is also quite large. This revision adds some responsiveness by: - pushing the top bar composer to the bottom of top bar when the latter is too narrow - hiding some items from the toolbar in a popover when necessary Task: 4562073
rrahir
force-pushed
the
master-responsive-rar
branch
from
53d8940 to
bf95e66
Compare
pro-odoo
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Nice one 👍 It's easier to read the topbar template now, and we can add items from odoo !
I have one concern, if we add an item from odoo, it will break the display with the hardcoded threshold :/
Didn't read all the tests, my comments are mainly nitpick.
I added a screenshot in the pad.
we could alternatively decide to set the section size in the registry itself, with a sequence. Otherwise we could decide to apply a rule by counting the number of items in each section and use it to define the thresholds. I don't know if we need it right now though |
rrahir
force-pushed
the
master-responsive-rar
branch
from
cbb9198 to
227940f
Compare
rrahir
commented
Feb 18, 2025
| import { useToolBarDropdownStore } from "../../helpers/top_bar_tool_hook"; | ||
| import { Menu } from "../../menu/menu"; | ||
|
|
||
| formatNumberMenuItemSpec; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist