[PERF] import/export XLSX #5660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
laa-odoo
force-pushed
the
master-perf-add-reverse-lookup-on-getItemId-laa
branch
from
58367c8 to
05efb53
Compare
laa-odoo
force-pushed
the
master-perf-add-reverse-lookup-on-getItemId-laa
branch
2 times, most recently
from
5ace8db to
27c595e
Compare
laa-odoo
changed the title
During data import/export snapshotting, getItemId is heavily used, and its reliance on deepEquals for item comparisons can be very time-consuming with large datasets. This commit replaces the deepEquals call with a cache lookup, using pre-populated stringified representations of the items. This optimization reduces the processing time during snapshotting. Tests on our largest datasets show a 30% improvement in overall import performance. Task: 4563258
Only declare the result array when necessary. Optimize element traversal based on type (array or object). Tests on our largest datasets show a 3% improvement in overall import performance. Task: 4563258
laa-odoo
force-pushed
the
master-perf-add-reverse-lookup-on-getItemId-laa
branch
from
27c595e to
a54d0e9
Compare
…or loop in addRows Previously, heavy PositionMap constants were declared within the for loop, leading to unnecessary overhead on each iteration. This change moves their declaration outside the loop to optimize performance. Task: 4563258
During data export, `pushElement` is heavily used, and its reliance on deepEquals for property comparisons can be very time-consuming with large datasets. This commit replaces the deepEquals call with a cache lookup, using pre-populated stringified representations of the properties. This optimization reduces the processing time during export. For these last two commits, testing on our largest datasets shows a 90% improvement in overall export perfomance. Task: 4563258
laa-odoo
force-pushed
the
master-perf-add-reverse-lookup-on-getItemId-laa
branch
from
a54d0e9 to
61d1524
Compare
anhe-odoo
reviewed
Feb 13, 2025
| result += getCanonicalRepresentation(item[i]); | ||
| } | ||
| return result + "]"; | ||
| } |
There was a problem hiding this comment.
Maybe we can do something like item.map(getCanonicalRepresentation).join(','), but I'm not sure about the performance
src/helpers/data_normalization.ts
Outdated
| @@ -45,3 +59,29 @@ export function* iterateItemIdsPositions(sheetId: UID, itemIdsByZones: Record<st | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| function getCanonicalRepresentation(item: any): string { | |||
There was a problem hiding this comment.
Maybe we can use number as the canonical representation of number and have number | string as the reverseLookup map key :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 4563258