[FW][FIX] collaborative: fix undo concurrence issues #5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some revisions undergo transformations that may cause issues with undo/redo if the transformation is destructive (we don't get back the original command by transforming it with the inverse). To prevent these problems, we must discard all subsequent local revisions. Here is a simple example to illustrate the issue: - Alice add some columns before "C" - Concurrently, Alice undo her action, Bob resize columns A to E - Alice's command is committed before Bob's command => The state is synchronized - Alice redo her action => The state is not synchronized anymore, as Bob contains in his history the resize command with columns A to E, but Alice has the resize command without the columns that has been removed by the undo. Task: 4558024 X-original-commit: 6d69933 Co-authored-by: Lucas Lefèvre <[email protected]> Co-authored-by: Pierre Rousseau <[email protected]>
|
|
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some revisions undergo transformations that may cause issues with undo/redo if the transformation is destructive (we don't get back the original command by transforming it with the inverse). To prevent these problems, we must discard all subsequent local revisions.
Here is a simple example to illustrate the issue:
=> The state is not synchronized anymore, as Bob contains in his history the resize command with columns A to E, but Alice has the resize command without the columns that has been removed by the undo.
Co-authored-by: Lucas Lefèvre [email protected]
Co-authored-by: Pierre Rousseau [email protected]
Task: 4558024
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #5657