Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[FIX] chart: handle tooltip with colons in the label
To split the labels and values in the tooltips, we did a simple split
by colon, since our labels had the format
label: value
. But thisobviously breaks when the label itself contains a colon.
With this commit, we now use the
beforeLabel
tooltip callback toget the label, and the
label
callback to get the value instead ofdoing everything in the
label
callback.[FIX] chart: remove empty title in tooltip
If there is no title in the tooltip, we still displayed the div
containing the title. That led to a small empty space at the top
of the tooltip.
Task: 4586683
review checklist