Skip to content

[IMP] xlsx: prevent exporting FILTER function #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Rachico
Copy link
Contributor

@Rachico Rachico commented May 5, 2025

The current implementation of the FILTER function is different from the one adopted by Excel, therefore this commit marks it as not exportable.

Task: 4766579

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 5, 2025

Pull request status dashboard

The current implementation of the FILTER `function` is different from the
one adopted by Excel, therefore this commit marks it as not exportable.

Task: 4766579
@Rachico Rachico force-pushed the master-prevent-exporting-filter-function-mera branch from 127f13f to 96696c0 Compare May 22, 2025 08:57
@Rachico Rachico changed the base branch from master to 17.0 May 22, 2025 08:57
@Rachico
Copy link
Contributor Author

Rachico commented May 22, 2025

Base is changed to 17.0 @pro-odoo

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request May 22, 2025
The current implementation of the FILTER `function` is different from the
one adopted by Excel, therefore this commit marks it as not exportable.

closes #6290

Task: 4766579
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo closed this May 22, 2025
@fw-bot fw-bot deleted the master-prevent-exporting-filter-function-mera branch May 29, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants